Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #274

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Allow Symfony 7 #274

merged 1 commit into from
Dec 1, 2023

Conversation

bocharsky-bw
Copy link
Member

No description provided.

@fpucci-git
Copy link

When is this request expected to be approved? Symfony 7 is out, and this bundle blocks the update

@bocharsky-bw
Copy link
Member Author

No cooe reviews of it yet... feel free to give a review to speed up the process :)

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@weaverryan
Copy link
Contributor

Thank you Victor!

@weaverryan weaverryan merged commit 2b42822 into main Dec 1, 2023
5 checks passed
@bocharsky-bw bocharsky-bw deleted the sf7 branch December 1, 2023 19:31
@xribant
Copy link

xribant commented Mar 16, 2024

Hello! Tried to install the bundle on a fresh symfony 7 installation and it blocked the make:migration with an error:

[Semantical Error] The class "Doctrine\ORM\Mapping\Column" is not annotated with @annotation.
Are you sure this class can be used as annotation?
If so, then you need to add @annotation to the class doc comment of "Doctrine\ORM\Mapping\Column".
If it is indeed no annotation, then you need to add @IgnoreAnnotation("ORM\Column") to the class doc comment of property App\Entity\ResetPasswordRequest::$selector.

Annotations are not supported anymore in Symfony 7 and even if old annotations were removed from the entity ResetPasswordRequest.php. It's still present in the trait file.

Remove old annotations from ResetPasswordRequestTrait.php in vendor/symfonycasts/reset-password-bundle/src/Model/ResetPasswordRequestTrait.php did the trick to permit the make:migration

@jrushlow
Copy link
Collaborator

Howyd @xribant - I've created an issue for your comment in #287. We'll address the problem there for better visibility :)

@SymfonyCasts SymfonyCasts locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants