Use miliseconds for statistics #43
Conversation
src/Storage/Doctrine/Connection.php
Outdated
| $table->addColumn('dispatched_at', Types::FLOAT)->setNotnull(true); | ||
| $table->addColumn('waiting_time', Types::FLOAT)->setNotnull(false); | ||
| $table->addColumn('handling_time', Types::FLOAT)->setNotnull(false); | ||
| $table->addColumn('failing_time', Types::FLOAT)->setNotnull(false); |
There was a problem hiding this comment.
Just an FYI for us, this will require a migration - iirc, make:migration will see this changes, but it's been awhile so I'm not 100% sure.
There was a problem hiding this comment.
looks like you can backfill these new columns, as they are calculated from the existing ones?
the existing ones can then be dropped
|
@bendavies now that CI is running, there's one tiny failure related to precision. Can you have a look? |
|
Interesting. That didn't happen on the original pr |
looks like this is due to floating point calculations in mariadb i'll see if switching the column types from float to decimal fixes this. |
bendavies
force-pushed
the
miliseconds-for-stats-rebased
branch
2 times, most recently
from
5648987
to
ae900bf
Compare
|
using decimals has fixed the tests |
store waiting_time in seconds+microseconds store handling_time in seconds+microseconds store failing_time in seconds+microseconds Fixed statistics computing Handle micro/milli seconds in twig time filter Tested retry behavior Fixed waiting_time for messages with delay
bendavies
force-pushed
the
miliseconds-for-stats-rebased
branch
from
469c5b4
to
1fed242
Compare
This is a rebased submission of #27
fixes #20
fixes #17
fixes #25
TODO: