Skip to content

Opening pull requests

Lireoy edited this page Mar 4, 2019 · 5 revisions

Opening pull requests

First, you will need to set up a development environment. After that, you can follow these steps:

  1. Modify your code: Add something or fix something like a command.
  2. Fixing standard: All the files in the repository are formatted on the JavaScript Standard Style. You can run npm run test to check the standards. You can also run npm run fix to fix some basic stuff like spaces, empty lines and so on.
  3. Once you finished coding, and is appropriate to standards, you can push your code, if you are part of our organization, you have to create a new branch. If you are not, then you have to push your code to your Fork.

Please remember to keep the branch name lowercase-and-only-usa-dashes-to-separate-words (no spaces). Example: youtube-command

  1. Pushing your code: Push your local changes like this:
git add . // to add your files to the git
git commit "My commit"
git push
  1. Create your pull request: After pushing your standard formatted code, you can now create a pull request selecting your branch or fork. Remember to describe in details what your change does or fixes, and remember to keep updated your code and fix requested changes or answer our reviews.