Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dereference + async #262

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

dereference + async #262

wants to merge 4 commits into from

Conversation

imsamurai
Copy link

@imsamurai imsamurai commented Apr 16, 2021

Hi, main goal this MR is dereference. But i think it's not ok to implement it separately from main logic, so what i made is:

  • fix bug with copy to paths properties that not start with /
  • make lib async (there was callback that doesn't work)
  • add oprion dereference for dereference $refs
  • fix dereference call to proper handle relative $ref path
  • do not ignore parse/dereference errors
  • update readme
  • update tests
  • new test for dereference
  • fix info, openapi and security properties in organize

@daniloab
Copy link
Collaborator

daniloab commented Jun 2, 2021

can you reference or create an issue that explains the motivation of this pr?

@imsamurai
Copy link
Author

The main goal is abillity to dereference $refs. Also pr contains few fixes that described above

@stale
Copy link

stale bot commented Aug 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 2, 2021
@daniloab daniloab added the pinned Issues that will not be automatically closed label Aug 2, 2021
@stale stale bot removed the wontfix label Aug 2, 2021
@menocomp
Copy link

menocomp commented Jan 1, 2023

I am looking at a way to dereference as well.
Any update on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Issues that will not be automatically closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants