Fixed -1 error in cnvmodel.c #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RemingtonRohel thanks for following up on this, I really appreciate it. I'll try to test this shortly. |
|
@egthomas I'm sorry you even had to ask, I should've caught this before making my original PR. If you find any issues with the binaries I'll fix them up as quick as I can. |
|
@RemingtonRohel this is on me, too, as code reviewer. I wish we had a unit test suite to catch these problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting error introduced with #620.
Tested by using
map_addmodel -old_aacgmfrom the commit before #620 was merged and verifying identical fields in the resulting map file. I used dmap to read in the files, then used straight equality checks for each field of each record.