Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Rum source #547

Merged
merged 15 commits into from
Jul 21, 2023
Merged

Add support for the Rum source #547

merged 15 commits into from
Jul 21, 2023

Conversation

dkluba
Copy link
Contributor

@dkluba dkluba commented Jul 13, 2023 •
edited
Loading 

=== RUN   TestAccSumologicRumSource_Mincreate
--- PASS: TestAccSumologicRumSource_Mincreate (7.21s)
PASS
ok  	github.com/SumoLogic/terraform-provider-sumologic/sumologic	7.660s

=== RUN   TestAccSumologicRumSource_Fullcreate
--- PASS: TestAccSumologicRumSource_Fullcreate (6.83s)
PASS
ok  	github.com/SumoLogic/terraform-provider-sumologic/sumologic	7.270s

=== RUN   TestAccSumologicRumSource_update
--- PASS: TestAccSumologicRumSource_update (11.24s)
PASS
ok  	github.com/SumoLogic/terraform-provider-sumologic/sumologic	11.797s

dkluba added 15 commits July 10, 2023 19:04
@dkluba
TRACING-3869 Add structs for RumSource
5c5739f
@dkluba
TRACING-3869 Add Create/Get/Update methods for RumSource
2565d72
@dkluba
TRACING-3869 Mark optional fields
7940fe8
@dkluba
TRACING-3869 Add terraform schema definition for Rum Source
136ec99
@dkluba
TRACING-3869 Add Create/Update/Read resource functions
8f1d5c9
@dkluba
TRACING-3869 Add RumSource resource deserialization
f1f225f
@dkluba
TRACING-3869 Add tests for rum source
0fd1433
@dkluba
TRACING-3869 Wire up Rum Source resource
89a2671
@dkluba
TRACING-3869 Fixes after tests
e6e2ec1
@dkluba
TRACING-3869 Add default content_type
6390227
@dkluba
TRACING-3869 Add RumSource update test
326765e
@dkluba
Merge remote-tracking branch 'origin/master' into dkluba-TRACING-3869…
f20ee54 
…-add-support-for-rum-source
@dkluba
TRACING-3859 tfproviderlint
4572036
@dkluba
TRACING-3869 Add rum source resource to the changelog
6076781
@dkluba
TRACING-3869 Add documentation for Rum Source
068a0ff
@dkluba dkluba marked this pull request as ready for review July 14, 2023 20:29
vsinghal13
vsinghal13 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We also need to think about migrating the existing RUM sources created via the HTTP resource to this new resource type.

@sumovishal sumovishal merged commit af186d6 into master Jul 21, 2023
2 of 3 checks passed
@sumovishal sumovishal deleted the dkluba-TRACING-3869-add-support-for-rum-source branch July 21, 2023 18:28
@vsinghal13 vsinghal13 mentioned this pull request Aug 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@maimaisie maimaisie Awaiting requested review from maimaisie maimaisie is a code owner

@sumovishal sumovishal Awaiting requested review from sumovishal sumovishal is a code owner

@dagould dagould Awaiting requested review from dagould

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkluba @vsinghal13 @sumovishal