Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import by name for v2 ingest budgets #474

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ambrosy-eric
Copy link
Contributor

Allow importing v2 budget via name

Issue related to

Related to 473

Copy link
Collaborator

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @ambrosy-eric for your contribution. Could you also add tests for the same?

@ambrosy-eric
Copy link
Contributor Author

Sure thing @vsinghal13

Where would be a good place to add a test? Looking at resource_sumologic_ingest_budget_v2_test.go I see a warning not to modify the file

// This file is automatically generated by Sumo Logic and manual
// changes will be clobbered when the file is regenerated. Do not submit
// changes to this file.

@vsinghal13
Copy link
Collaborator

Sure thing @vsinghal13

Where would be a good place to add a test? Looking at resource_sumologic_ingest_budget_v2_test.go I see a warning not to modify the file

// This file is automatically generated by Sumo Logic and manual
// changes will be clobbered when the file is regenerated. Do not submit
// changes to this file.

It's fine, you can add to the same file. We are not currently overriding these files.

@ambrosy-eric
Copy link
Contributor Author

sorry @vsinghal13 for the extremely log delay. Tried adding name import to the existing test. Lmk if that's acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants