Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make display_template look like a daterm #232

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

BryceStevenWilley
Copy link
Contributor

They serve the same function (tap to get more information, and they don't navigate you away from the page), so it makes sense to brand them the same.

I'm not quite used to it yet, but I do think I will with a bit of time. Also have to keep in mind that most users aren't coming back again and again, they use our side a few times and don't return.

Fixes #208

Screenshot from 2023-12-13 20-46-57

They serve the same function (tap to get more information, and they don't
navigate you away from the page), so it makes sense to brand them the same.

Fixes #208
Copy link
Member

@nonprofittechy nonprofittechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right it will take a bit to get used to, but I think it's the right change. Looks good to merge

@BryceStevenWilley BryceStevenWilley merged commit 3ffaedb into main Dec 14, 2023
4 checks passed
@BryceStevenWilley BryceStevenWilley deleted the display_template_ui branch December 14, 2023 14:47
@miabonardi
Copy link

Is this only supposed to work on collapse_template? I am seeing difference between collapse and display templates

Screen Shot 2023-12-14 at 1 06 32 PM

BryceStevenWilley added a commit that referenced this pull request Dec 14, 2023
Addition onto #208, which should have fixed this for collapsible display
templates too, but didn't because they didn't use the same classes, for
no reason that I can see: `al_toggle` wasn't used in style sheets before
#232.

Have already tested, going to merge.

![Screenshot from 2023-12-14
13-41-40](https://github.com/SuffolkLITLab/docassemble-ALToolbox/assets/6252212/3ab6a1ce-d48e-4a23-8550-b7d8f8657bf6)
@ekressmiller
Copy link

For us this comes out looking beautiful in Firefox:
image

But kind of hard to read in Chrome:
image

I think the chunky dashes underneath become more of an issue with longer stretches of text like in the template headers. I'll think about it/look into what we can do on our servers but just wanted to mention it!

@BryceStevenWilley
Copy link
Contributor Author

Good spot, I agree that the Chrome one isn't very readable. You can use some CSS in your interview to adjust it:

.al_collapse_template a.al_toggle, .al_display_template a.al_toggle {
  text-underline-offset: 3px;
}

Here's a screenshot: Left is chrome, right is firefox.

Screenshot from 2024-01-16 23-07-19

There's also text-decoration-thickness. Not sure how widely supported both are, but it might be good to space out the Chrome one a bit in AL core. Annoying that the browser's have horrible readability defaults.

(I didn't check, but you might want to see what the terms look like in chrome. I'm pretty sure I used the same CSS as the terms used, and if you fix this CSS, you'll want to fix the term CSS as well).

@ekressmiller
Copy link

Thanks Bryce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change display_template() links to green words color with same dotted underline
4 participants