-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make display_template look like a daterm #232
Conversation
They serve the same function (tap to get more information, and they don't navigate you away from the page), so it makes sense to brand them the same. Fixes #208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right it will take a bit to get used to, but I think it's the right change. Looks good to merge
Addition onto #208, which should have fixed this for collapsible display templates too, but didn't because they didn't use the same classes, for no reason that I can see: `al_toggle` wasn't used in style sheets before #232. Have already tested, going to merge. ![Screenshot from 2023-12-14 13-41-40](https://github.com/SuffolkLITLab/docassemble-ALToolbox/assets/6252212/3ab6a1ce-d48e-4a23-8550-b7d8f8657bf6)
Good spot, I agree that the Chrome one isn't very readable. You can use some CSS in your interview to adjust it: .al_collapse_template a.al_toggle, .al_display_template a.al_toggle {
text-underline-offset: 3px;
} Here's a screenshot: Left is chrome, right is firefox. There's also (I didn't check, but you might want to see what the terms look like in chrome. I'm pretty sure I used the same CSS as the terms used, and if you fix this CSS, you'll want to fix the term CSS as well). |
Thanks Bryce! |
They serve the same function (tap to get more information, and they don't navigate you away from the page), so it makes sense to brand them the same.
I'm not quite used to it yet, but I do think I will with a bit of time. Also have to keep in mind that most users aren't coming back again and again, they use our side a few times and don't return.
Fixes #208