Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added shortkey to toggle caption. UX improvement. #675

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

added shortkey to toggle caption. UX improvement. #675

wants to merge 3 commits into from

Conversation

GaryGosh
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tymmesyde
Copy link
Member

Hi! Thank you for your PR, can you sign the CLA?
For this to work well it needs some kind of memory logic
For example let's say that you selected the third english subtitle, if you hide the subtitles and show them again, it will select the first subtitles in the list but it should use the same that was previously selected

@GaryGosh
Copy link
Author

thank you very much for your feedback . sure I will add that

@GaryGosh
Copy link
Author

@tymmesyde have updated my pr . pls review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaryGosh @CLAassistant @tymmesyde