Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to specify SSL protocol #109

Open
wants to merge 2 commits into
base: branch-0.5
Choose a base branch
from

Conversation

jniebuhr
Copy link

Fixes #107

@nelsou
Copy link
Contributor

nelsou commented Jun 26, 2017

if (useSslConnection(params)) { factory.useSslProtocol(getSslProtocol(params)) }

shouldn't it be in the addConnection instead of the getChannel ?

@jniebuhr
Copy link
Author

It seems to be a global setting which is not used on the connection but on the factory. So I assumed this was the right spot.

@compae
Copy link
Member

compae commented Aug 18, 2017

Could you add some tests?? I think that you need to initialize the keyManager and the trustManager...

@jniebuhr
Copy link
Author

Yes, I'll do that

@jniebuhr
Copy link
Author

If the test should be some kind of integration test, you'll need to change the jenkins setup to include some RabbitMQ with SSL

@jniebuhr
Copy link
Author

I've added the tests now. The image I used was https://github.com/roboconf/rabbitmq-with-ssl-in-docker
I had to change fail_if_no_peer_cert to false though, which makes sense.

@jniebuhr
Copy link
Author

A TrustManager instance is added automatically by the driver. I didn't find anything about a KeyManager in the docs, but I assume you'll need that one for client cert auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants