Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formulas for bispectrum in fourier.py #640

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Feb 21, 2022

Not for the 1.0 release.
I had drafted these functions to work on my time series analysis classes, and Issue #639 was a good excuse to start thinking about using them in Stingray :)

@pep8speaks
Copy link

pep8speaks commented Feb 21, 2022

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:101: E501 line too long (102 > 100 characters)

Comment last updated at 2022-02-24 10:45:49 UTC

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #640 (9bad0b5) into main (8b4b3e7) will decrease coverage by 0.46%.
The diff coverage is 12.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   97.21%   96.75%   -0.47%     
==========================================
  Files          41       41              
  Lines        7535     7576      +41     
==========================================
+ Hits         7325     7330       +5     
- Misses        210      246      +36     
Impacted Files Coverage Δ
stingray/fourier.py 93.28% <3.84%> (-6.45%) ⬇️
stingray/bispectrum.py 87.95% <26.66%> (-6.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4b3e7...9bad0b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants