Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontpage suggestions. #760

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Conversation

LeMurphant
Copy link
Collaborator

I still think ideally the title should be fetched from the page directlly and not specified here

I still think ideally the title should be fetched from the page
directlly and not specified here
@mruwnik
Copy link
Collaborator

mruwnik commented Aug 29, 2024

agreed :/

Also, you'll have to run npm run lint:fix

@LeMurphant
Copy link
Collaborator Author

LeMurphant commented Sep 6, 2024

@mruwnik I ran the command and got an error in a file I did not modify. The error also shows up on the master branch.

stampy-ui/node_modules/typescript/lib/tsc.js:93
  for (let i = startIndex ?? 0; i < array.length; i++) {
                           ^

SyntaxError: Unexpected token '?'

@mruwnik
Copy link
Collaborator

mruwnik commented Sep 8, 2024

huh. This is a typescript error, which is concerning. Have you updated your node modules recently? Does removing them and reinstalling work (rm -R node_modules && npm install)?

@LeMurphant
Copy link
Collaborator Author

Ubuntu jammy had installed npm v8.5, I manually updated to v22.8.0 and it works.

@mruwnik mruwnik merged commit 4c20fa4 into master Sep 8, 2024
1 check passed
@mruwnik mruwnik deleted the update_frontpage_objections branch September 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants