Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe with link fix #317

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Iframe with link fix #317

merged 3 commits into from
Sep 15, 2023

Conversation

Aprillion
Copy link
Collaborator

  • it didn't work after merge (because handleSpecialLinks has a condition url.hostname === window.location.hostname that was false on localhost and test envornment)
  • so I reverted the merge
  • and now redoing the changes + fixing the issue

@Aprillion
Copy link
Collaborator Author

The deployed version after revert merge is still broken 🤔 merging this PR now and if there are left-over bugs we can solve later 🍀

@Aprillion Aprillion merged commit 7f73900 into master Sep 15, 2023
1 check passed
@Aprillion Aprillion deleted the iframe-with-link-fix branch September 15, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant