-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pants managed venv in Makefile #6130
Draft
cognifloyd
wants to merge
92
commits into
master
Choose a base branch
from
pants-export-venv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
size/L
PR that changes 100-499 lines. Requires some effort to review.
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
and removed
size/L
PR that changes 100-499 lines. Requires some effort to review.
labels
Feb 10, 2024
cognifloyd
force-pushed
the
pants-export-venv
branch
5 times, most recently
from
February 10, 2024 23:25
7190169
to
8baa519
Compare
cognifloyd
force-pushed
the
pants-export-venv
branch
from
February 16, 2024 21:09
423d9b4
to
173dde2
Compare
The pants-managed venv does not have PyOpenSSL.
I don't know if that's related to the timeouts in the integration tests or not. Nope. That's irrelevant because we're already pinned to requests==2.25.1, so we're only getting pyopenssl because of our pin now. If we dropped that it would probably go away. We can also drop the |
cognifloyd
force-pushed
the
pants-export-venv
branch
from
February 19, 2024 17:48
75b3502
to
fdedead
Compare
GHA isn't failing with the RabbitMQ errors anymore. Hopefully the hack isn't actually needed. Lockfile diff: lockfiles/st2.lock [st2] == Removed dependencies == pyopenssl 24.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == amqp 5.0.6 --> 5.2.0 vine 5.0.0 --> 5.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == bcrypt 3.2.2 --> 4.1.2
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == greenlet 1.1.3.post0 --> 3.0.3
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == tenacity 6.3.1 --> 8.2.3
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == oslo-utils 4.13.0 --> 7.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == cffi 1.14.6 --> 1.16.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == kombu 5.0.2 --> 5.3.6 == Added dependencies == typing-extensions 4.11.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == stevedore 2.0.1 --> 5.2.0
cognifloyd
added a commit
that referenced
this pull request
Apr 10, 2024
Using the pants venv, the tests all pass with these requirements. I hacked the Makefile to test that in CI in #6130. This extracts just the requirements bits from that PR. Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == amqp 5.0.6 --> 5.2.0 bcrypt 3.2.0 --> 4.1.2 cffi 1.14.6 --> 1.16.0 eventlet 0.30.3 --> 0.36.1 filelock 3.13.3 --> 3.13.4 kombu 5.2.2 --> 5.3.6 oslo-utils 4.13.0 --> 7.1.0 stevedore 2.0.1 --> 5.2.0 tenacity 6.3.1 --> 8.2.3 vine 5.0.0 --> 5.1.0 == Added dependencies == typing-extensions 4.11.0
Merged
pull-request-size
bot
added
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
and removed
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
labels
Apr 15, 2024
By default, pants+pex adds `-sE` to the virtualenv/bin scripts which prevents PYTHONPATH and other PYTHON* vars from affecting the program. st2-run-pack-tests uses PYTHONPATH, however, so bypass the script if it is hermetic.
to make sure this new method works for running nosetests.
This was referenced Apr 15, 2024
pull-request-size
bot
added
size/L
PR that changes 100-499 lines. Requires some effort to review.
and removed
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
labels
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
external dependency
infrastructure: ci/cd
no changelog
No Changelog.rst needed for this PR
pantsbuild
size/L
PR that changes 100-499 lines. Requires some effort to review.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't intend to merge this. I want to use this to find any issues with the requirements pants is using and limit them appropriately. So, the changes to the Makefile are quite hacky.