Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous revision number #394

Closed
wants to merge 1 commit into from
Closed

Conversation

enykeev
Copy link
Member

@enykeev enykeev commented Dec 16, 2016

During another task it suddenly occurred to me that we can noticeably simplify package deployment and avoid revision number collision and desynchronization if, instead of sequential revision number, we start using CircleCI build number.

@enykeev
Copy link
Member Author

enykeev commented Dec 16, 2016

There is no particular need to fix it now and there might be some unforeseen consequences of that, but using build number as revision certainly makes sense to me, could potentially simplify some debug scenarios and even play part in new CI effort.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deb/rpm packaging should follow the incremental build numbers. From the policy:

release is the number of times this version of the software has been packaged.

Every new version should start with consistent 1 revision/release number. I would follow deb/rpm best practices and recommendations.

While this looks like cool hack, please, let's not do this like bros :)

@enykeev
Copy link
Member Author

enykeev commented Dec 19, 2016

It is conventional to restart the debian_revision at 1 each time the upstream_version is increased.

We don't really follow this convention strictly during package promotion though. If the package with revision 1 will fail the test, it would never get promoted to unstable repo and the next revision number would be determined based on latest unstable-staging revision number.

As with any other convention, we are the one who decides how rigorously we want to follow it. I'm personally still thinking it would be highly beneficial for us to have continuous numbering scheme matching ever increasing build number, but feel free to close the PR if team disagrees.

I've opened #395 and #396 for us to keep an eye on the problems with revision number we're currently having.

@enykeev enykeev closed this Jul 27, 2018
@arm4b arm4b deleted the feature/continuous_revision branch July 27, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants