#36: Update index and events to use class based views #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,4 +67,7 @@ class GetTechGroups(GenericHtmxView): | |||
| class GetEvents(GenericHtmxView): | |||
| """Get a list of upcoming Events and render a partial to use on the sidebar navigation""" | |||
| template_name = "web/partials/sidebar_items.htm" | |||
| queryset = Event.objects.filter(date_time__gte=timezone.now()) | |||
|
|
|||
| def __init__(self, **kwargs): | |||
There was a problem hiding this comment.
super-ing should not be necessary here; looks like I borked the GenericHtmxView; there should be an init there. I'll fix that and update this after.
There was a problem hiding this comment.
I just added the super as a best-practice, though it might not be necessary for this base class.
I moved the queryset into __init__ because otherwise timezone.now() is only calculated once when the class is first parsed, since it was a class-level variable, not an instance variable.
davidslusser
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description:
Related Issues:
Checklist:
Screenshots
Index
Event detail
Events list
