Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce django-environ #136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

artsyjian
Copy link

Pull Request

Description:

  • Introduce django-environ
  • Switch to django-environ for most env vars that are read in settings.py.

Related Issues:

Checklist:

  • All tests pass.
  • Code follows the project's coding standards.
  • Documentation has been updated.

Copy link
Contributor

@joeriddles joeriddles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Congrats on the first commit to Spokane Tech! Thank you :)

Copy link
Collaborator

@KGB33 KGB33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing (I also just approve the Actions runs here, @me in the Discord or on here if they need approval again).

$ dagger -m github.com/artsyjian/SpokaneTech_Py call linters all

PASSED! Command ruff check passed!
PASSED! Command bandit -c pyproject.toml -r src passed!

FAILED! Command `src/manage.py check` failed with exit code 1.
FAILED! Command `ruff format --check` failed with exit code 1.
FAILED! Command `pytest -vv --config-file pyproject.toml src` failed with exit code 1.

It looks like Pytest & Django should pass once the lockfiles are updated.

Thanks for the contribution and let me know if you have any questions!

pyproject.toml Show resolved Hide resolved
@artsyjian artsyjian requested a review from KGB33 September 9, 2024 14:40
Copy link
Collaborator

@KGB33 KGB33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants