Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test error handling for SPI code #315

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Test error handling for SPI code #315

wants to merge 32 commits into from

Conversation

kamilchmela
Copy link
Contributor

@kamilchmela kamilchmela commented Jul 25, 2024 •
edited by PatrickKa
Loading

Fixes #305

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.18182% with 54 lines in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (d2088ec) to head (1ac2489).
Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
Sts1CobcSw/Periphery/FlashMock.cpp 0.00% 54 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #315       +/-   ##
===========================================
- Coverage   97.69%   83.92%   -13.77%     
===========================================
  Files          33       38        +5     
  Lines        1039     1406      +367     
  Branches       25       50       +25     
===========================================
+ Hits         1015     1180      +165     
- Misses         24      226      +202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrickKa PatrickKa force-pushed the test-error-handling-for-spi branch from 7e5fde1 to 994e1bb Compare July 27, 2024 11:08
PatrickKa
PatrickKa requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@PatrickKa PatrickKa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • FlashMock.hpp only needs to declare what is necessary for mocking in addition to Flash.hpp. That means you need to remove everything up to and including extern hal::Spi spi; and include Flash.hpp instead. Also remove the duplicated comments at the top of the file.

Sts1CobcSw/Periphery/CMakeLists.txt Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/FlashMock.cpp Outdated Show resolved Hide resolved
Sts1CobcSw/Periphery/FlashMock.cpp Outdated Show resolved Hide resolved
Tests/HardwareTests/CMakeLists.txt Outdated Show resolved Hide resolved
@PatrickKa PatrickKa force-pushed the test-error-handling-for-spi branch 2 times, most recently from 3c9064f to 72944b6 Compare September 3, 2024 19:09
kamilchmela and others added 21 commits September 16, 2024 11:59
@kamilchmela
Add debug messages
c20e46f
@kamilchmela
Add PeripherySupervision.test.cpp
ff55031
@kamilchmela
Change CMakeLists.txt
7adb357
@kamilchmela
Fix errors
00fa557
@PatrickKa @kamilchmela
Refactor debug messages of SPI supervisor and test threads
0798751 
- Use proper English grammar and spelling
- Add missing line breaks
@PatrickKa @kamilchmela
Rename PeripherySupervision.test.cpp to SpiSupervisor.test.cpp
a82ad0b 
Rename PeripherySupervision to SpiSupervisor, part 2
@PatrickKa @kamilchmela
Add rfLatchupDisableGpioPin to SpiSupervisor.test.cpp
0035f1f
@PatrickKa @kamilchmela
Add missing dependency of SPI supervisor test
e261ec7
@PatrickKa @kamilchmela
Refactor SpiSupervisor.test.cpp
f53084f
@PatrickKa @kamilchmela
Fix includes in SpiSupervisor.test.cpp
2fbbfee
@kamilchmela
Add FlashMock.cpp/hpp
d4d5cf5
@kamilchmela
Fix CmakeLists in HardwareTests
342a30f
@kamilchmela
Define JedecID
b29c4bf
@kamilchmela
Undo quotations
0466678
@kamilchmela
Fix namespaces
7d63f86
@kamilchmela
Fix format
15544cb
@kamilchmela
Fix some small things
7dde158
@kamilchmela
Remove delay
4c4eeae
@kamilchmela
Resolve review requests
c3b3420
@kamilchmela
Fix maybe_unused bug
4863ed5
@kamilchmela
Add StartupTestStubs.cpp
044db85
@kamilchmela kamilchmela force-pushed the test-error-handling-for-spi branch 3 times, most recently from afebffb to e7de75c Compare September 16, 2024 12:54
@PatrickKa PatrickKa force-pushed the test-error-handling-for-spi branch 3 times, most recently from 72db7b8 to 23dee52 Compare September 22, 2024 17:53
PatrickKa and others added 6 commits September 23, 2024 18:36
@PatrickKa
Use new time types and functions
bd65d5d
@kamilchmela @PatrickKa
Use PImpl idiom for Spi class
e70d4eb
@PatrickKa
Fix includes
595919f
@PatrickKa
Refactor time functionality into Rodos and real time parts
a19eed6 
This makes it easier to avoid cyclic dependencies.
@PatrickKa
Add TimeTypes.[hi]pp again
8675043 
We actually do need this to break the cyclic dependency between
`RealTime.hpp` and `FramLayout.hpp`.
@PatrickKa
Fix includes
54f7c8a
@kamilchmela kamilchmela force-pushed the test-error-handling-for-spi branch 3 times, most recently from fe01b0d to 09d9d18 Compare September 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickKa PatrickKa PatrickKa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test error handling for SPI code
3 participants
@kamilchmela @codecov-commenter @PatrickKa