fix: translate phone input placeholder and message #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edit component of phone property was missing translations.
dziraf
requested changes
Mar 1, 2023
| @@ -27,6 +31,8 @@ const Edit: FC<EditPropertyProps> = (props) => { | |||
| name: property.path, | |||
| required: property.isRequired, | |||
| }} | |||
| searchPlaceholder={translateLabel('search', resource.id)} | |||
There was a problem hiding this comment.
Let's use translateMessage for placeholder too, translateLabel is mostly used for translating some headers.
There was a problem hiding this comment.
Could you also add translations to the core translations for all languages? We usually just use https://www.deepl.com/en/translator for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit component of phone property was missing translations.