Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Inner Outer Inner wall ordering mode failed to reorder in certain edge cases with arachne #7134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Oct 16, 2024

Description

In certain cases where the internal perimeter line width was significantly larger than the external perimeter line width, IOI mode failed to re order the external perimeters correctly.

This was due to the safety margin for perimeter overlap (10%) that was introduced in the previous IOI rework PR.

Reducing this to 2%, just to cover edge cases caused due to numerical precision, fixes these edge cases while also retaining correct wall ordering.

Can reduce to 0% with the wall ordering still working correctly; however the slight increase in the search radius helps mitigate potential numerical precision issues where the neighbouring perimeter is just a "hair" further apart than the computed search radius.

Screenshots/Recordings/Graphs

Before
The middle bridge was incorrectly "attached" to the previous island due to proximity calculation being tripped up due to the artificially increased overlap.
image

After:
Correctly sequenced perimeters as per IOI
image

@igiannakas igiannakas changed the title Bug fix: Inner Outer Inner failed to reorder in certain edge cases Bug fix: Inner Outer Inner wall ordering mode failed to reorder in certain edge cases with arachne Oct 16, 2024
@TomKamin1
Copy link

Hi! I am the edge case, and the problem is completely solved. Here's a before and after of how the problem looked on the part.
image
IMG_1970

@igiannakas
Copy link
Contributor Author

@SoftFever, any chance we can sneak that in 2.2? 😀😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants