Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiates beta releases. Always shows release notes as text. #7067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernarden
Copy link
Contributor

Description

  • Removes Preview overwrite for pre-releases so that Semver can differentiate/compare the versions better.
  • Also removes the logic that tries to find a URL to load in the release notes. This used to cause blank release notes for releases that had 3x ### followed by a URL in the description. v2.2.0-rc is a good example of this.

Screenshots/Recordings/Graphs/Tests

Applied this change to versions 2.1.0 and 2.2.0 beta so I could test both stable and unstable functionality.

2.1.0 Before

Stable finds 2.1.1
image
Unstable finds 2.2.0 beta (Even though beta2 and rc are already released)
image

2.1.0 After

Stable finds 2.1.1
image
Unstable finds 2.0.0 rc
image

2.2.0-beta Before

Stable finds nothing newer
image
Unstable finds nothing newer
image

2.2.0-beta After

Stable finds nothing newer
image
Unstable finds 2.2.0 rc
image
Unstable finds 2.2.0 beta2 when I manually remove 2.2.0 rc from the api response.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant