Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creality K1 SE, K2 Plus, & CR-M4 #7002

Merged
merged 16 commits into from
Oct 7, 2024
Merged

Conversation

cochcoder
Copy link
Contributor

@cochcoder cochcoder commented Oct 3, 2024

Closes #6984, closes #6707, closes #6957

*Some max speeds/accelerations changes for the 0.4 nozzle was left out as none of the other nozzles had these max speeds/accelerations
I have no clue how I missed these
Seriously, how do I miss these
This reverts commit 08800dc.
resources/profiles/Creality.json Outdated Show resolved Hide resolved
@cochcoder cochcoder marked this pull request as ready for review October 4, 2024 23:49
@bistory
Copy link
Contributor

bistory commented Oct 6, 2024

Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-)
And max speed is 800, not 1000 :-)

@cochcoder
Copy link
Contributor Author

Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-)

And max speed is 800, not 1000 :-)

Thanks for noticing this, where do you see this from Creality? In the version of CrealityPrint that I have it is set to 20k for max acceleration and 800 for max speed.

@bistory
Copy link
Contributor

bistory commented Oct 6, 2024

Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-)
And max speed is 800, not 1000 :-)

Thanks for noticing this, where do you see this from Creality? In the version of CrealityPrint that I have it is set to 20k for max acceleration and 800 for max speed.

I checked on the latest creality print release with the newest profiles, here is the screenshot ;-)

Capture d’écran 2024-10-06 à 16 20 00

@cochcoder
Copy link
Contributor Author

Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-)
And max speed is 800, not 1000 :-)

Thanks for noticing this, where do you see this from Creality? In the version of CrealityPrint that I have it is set to 20k for max acceleration and 800 for max speed.

I checked on the latest creality print release with the newest profiles, here is the screenshot ;-)

Capture d’écran 2024-10-06 à 16 20 00

Ah I see now, I left those values out as they seemed incorrect (mainly with the jerk values). I went with the maximum values from the 0.2, 0.6, 0.8 nozzles as they seem to be the correct ones. What do you think?

image

@bistory
Copy link
Contributor

bistory commented Oct 6, 2024

Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-)
And max speed is 800, not 1000 :-)

Thanks for noticing this, where do you see this from Creality? In the version of CrealityPrint that I have it is set to 20k for max acceleration and 800 for max speed.

I checked on the latest creality print release with the newest profiles, here is the screenshot ;-)
Capture d’écran 2024-10-06 à 16 20 00

Ah I see now, I left those values out as they seemed incorrect (mainly with the jerk values). I went with the maximum values from the 0.2, 0.6, 0.8 nozzles as they seem to be the correct ones. What do you think?

image

Usually with Creality, only 0.4 profile can be trusted, the others have high chances to be incorrect. The K2 is advertised as being able to do 30kmm/s2 so it seems correct. But without being able to get a copy of the printer.cfg, I'm not able to confirm the data.
I hope I will be able to get a K2 so I will be able to test it against Orca profiles ;-)

@cochcoder
Copy link
Contributor Author

I'd go with the 0.4 nozzle version if it wasn't for the jerk values. Do you think that the 300m/s jerk values are correct?

@bistory
Copy link
Contributor

bistory commented Oct 6, 2024

If it didn't change, jerk values are ignored by Klipper, it is only useful for the slicer to be able to estimate print time accurately. To avoid those values to be converted to SQV instructions by Orca, we can put some more realistic values like 20mm/s. Probably reuse the same values as Qidi uses for its new X-Plus 4 which advertise the same speeds ;-)

@cochcoder
Copy link
Contributor Author

Done!

@cochcoder cochcoder changed the title Add Creality K1 SE & K2 Plus Add Creality K1 SE, K2 Plus, & CR-M4 Oct 6, 2024
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit 01ffeb6 into SoftFever:main Oct 7, 2024
1 check passed
@SoftFever
Copy link
Owner

Merged.
Thank you both!

@cochcoder cochcoder deleted the K1-SE branch October 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you add k1 SE to orca ? Please add a Creality CR-M4 profile Adding Creality K2 plus
4 participants