-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Creality K1 SE, K2 Plus, & CR-M4 #7002
Conversation
*Some max speeds/accelerations changes for the 0.4 nozzle was left out as none of the other nozzles had these max speeds/accelerations
I have no clue how I missed these
Seriously, how do I miss these
This reverts commit 08800dc.
Hi, nice job ! However max accelerations for K2 are 30000mm/s2, not 20k ;-) |
Thanks for noticing this, where do you see this from Creality? In the version of CrealityPrint that I have it is set to 20k for max acceleration and 800 for max speed. |
I'd go with the 0.4 nozzle version if it wasn't for the jerk values. Do you think that the 300m/s jerk values are correct? |
If it didn't change, jerk values are ignored by Klipper, it is only useful for the slicer to be able to estimate print time accurately. To avoid those values to be converted to SQV instructions by Orca, we can put some more realistic values like 20mm/s. Probably reuse the same values as Qidi uses for its new X-Plus 4 which advertise the same speeds ;-) |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you
Merged. |
Closes #6984, closes #6707, closes #6957