FIX: CLI: fix an exception when parsing scale params #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SoftFever just saw I added one parenthesis too many, on 3587. Should I do another pull request ? |
|
Nevermind, just saw you fixed it in 1c43b29 Thank you and sorry for the inconvenience. |
No issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to solve an exception when using OrcaSlicer in CLI which caused the --scale option to not work.
All credits to @lanewei120 from BambuStudio for pushing it on BS repo.
Related commit on BS:
bambulab/BambuStudio@2d4655e#diff-2fa194122e892282ec589e51d5f7da65da83ec0488ced4b63930345d1273a353R3797
Related issue on BS:
bambulab/BambuStudio#4628
Related issue on Orca:
#6454
fixes #6454
Tests
The command above works again and scale the model then slice the scaled model. Before, the scale would not complete.