Added Russian translation for missing phrases (2.1.1) #6778
Conversation
|
@SoftFever Yeah, no problem. The tests didn't run before. I'll take a look at them now and fix them. |
| @@ -13764,8 +14062,8 @@ msgstr "" | |||
| "органический). В то время как гибридный стиль создаёт структуру, схожую с " | |||
| "обычную поддержкой при больших плоских нависаниях." | |||
|
|
|||
| msgid "Default (Grid/Organic" | |||
| msgstr "" | |||
| msgid "Default (Grid/Organic)" | |||
There was a problem hiding this comment.
| msgid "Default (Grid/Organic)" | |
| msgid "Default (Grid/Organic" |
Reverted the change of the key by which the translation is searched.
There was a problem hiding this comment.
I'll leave it as undecided so that this change can be seen.
|
Thanks @andrey-helldar Unfortunately, the check won't run automatically for the first time contributor, I have to manually trigger it. |
| @@ -10963,9 +11118,27 @@ msgid "" | |||
| "and for when tool changing.\n" | |||
| "\n" | |||
| msgstr "" | |||
There was a problem hiding this comment.
@SoftFever I fixed two of the bugs, but there was a problem with the third. I have reconsidered the formation of the string itself and I don't understand what it is complaining about:
./localization/i18n/ru/OrcaSlicer_ru.po:11120: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.
In this place, the only thing to pick on is the “%” symbol. But it occurs once, just like in the original text.
I also compared its occurrence with other translation keys, as well as the c-format format, and I don't understand what could be the reason. Any ideas how to fix it?
There was a problem hiding this comment.
I've removed the format checking, but I don't know if that's the right thing to do. Although after that the tests passed successfully.
There was a problem hiding this comment.
This change is fine.
Sometimes the get text will confuse.
Description
Screenshots/Recordings/Graphs
Tests