Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlasForge Adventurer 3 machine start gcode fix #6282 #6312

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

GabrielJanucik
Copy link
Contributor

Description

For every project in FlashForge Adventurer 3 printer custom line was created on the edge of print field making sliced project impossible to print (line was out of plate). Default gcode for machine has been changed around 3 months ago. I have removed new code and now default start gcode is the same as provided in offical Adv3 manual. Code has been tested on my machine before push.

Screenshots/Recordings/Graphs

Screenshot from 2024-07-29 11-18-55

Tests

Tested with calibration and custom files on linux (Ubuntu 22.04) and printed.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit 74775c9 into SoftFever:main Aug 2, 2024
1 check passed
@RikshaDriver
Copy link
Contributor

@GabrielJanucik I am the author of ALL the Adventurer 3 parameters added into OrcaSlicer thus far. This change was added to allow a pre-extrusion as the printer needs it.

FYI, the print is not actually out of plate as the printable area is larger than the quoted 150x150mm dimensions, but Flashprint will complain it is. This is likely what you're seeing.

If you wish to change anything, adjust the Y -75 values to something like Y -74.5

@SoftFever please revert this change

@GabrielJanucik
Copy link
Contributor Author

GabrielJanucik commented Sep 10, 2024

@RikshaDriver but pre-extrusion is always added anyway on any custom objects. I agree that it doesn't appear on calibration prints and understand that is needed.

EDIT: I also saw people complaining about this bug few times on FlashForge users Fb groups. Sometimes there were other people giving them advice to edit that start code but sometimes I was the first one.

Here is preview of benchy sliced with mine changes and there is pre-extrusion/skirt around the object.
Screenshot from 2024-09-10 09-16-07

@SoftFever
Copy link
Owner

@RikshaDriver but pre-extrusion is always added anyway on any custom objects. I agree that it doesn't appear on calibration prints and understand that is needed.

EDIT: I also saw people complaining about this bug few times on FlashForge users Fb groups. Sometimes there were other people giving them advice to edit that start code but sometimes I was the first one.

Yeah, some people prefer skirt others prefer custom prime line.

Back to the original issue.
By right, Y-75 should be a valid coordinate per machine's definition.
It's might be a bug in their firmware.

I agree with @RikshaDriver here that changing it to Y-74.5 is a good idea.
@GabrielJanucik What do you think?

@GabrielJanucik
Copy link
Contributor Author

@SoftFever I think that now I understand it, at least more so I agree with that. Do you want me to create new PR with revert and value change?

@SoftFever
Copy link
Owner

@SoftFever I think that now I understand it, at least more so I agree with that. Do you want me to create new PR with revert and value change?

Yes, a new PR is appreciated!

@GabrielJanucik
Copy link
Contributor Author

New PR created #6744

@GabrielJanucik GabrielJanucik deleted the bugfix_6282 branch September 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants