Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styrene Butadiene Styrene (SBS) - Template and profiles for Bambu #6278

Merged
merged 15 commits into from
Aug 11, 2024

Conversation

dgauche
Copy link
Contributor

@dgauche dgauche commented Jul 29, 2024

Description

Addresses: issue 5980

  • Added Styrene Butadiene Styrene (SBS) to templates allowing you to create specific configurations of the filament
  • Added Generic SBS to Bambu Printers

This is a very popular filament in South Africa with multiple manufacturers.

Examples:
https://www.filx.co.za/products/sbs/
https://dc3dprinters.co.za/product/sa-filament-sbs-plus-1-75mm-white-750g/

Screenshots/Recordings/Graphs

Screenshot 2024-07-28 at 21 18 32
Screenshot 2024-07-28 at 21 19 28
Screenshot 2024-07-28 at 21 18 51

Tests

@dgauche
Copy link
Contributor Author

dgauche commented Jul 29, 2024

@SoftFever could you please review?

@dgauche dgauche mentioned this pull request Jul 29, 2024
1 task
@dgauche
Copy link
Contributor Author

dgauche commented Jul 31, 2024

I can see that the flatpack build failed, it is however not clear to me why, or if that matters. I have built this for mac locally and it seems that for the automated testing it also builds for all the other platforms.... @SoftFever I would appreciate some guidance here. Thanks.

@ElectricalBoy
Copy link
Contributor

I can see that the flatpack build failed, it is however not clear to me why, or if that matters

It seems to have been broken on main for a while now, so I would assume it to be irrelevant to this PR

@dgauche
Copy link
Contributor Author

dgauche commented Aug 1, 2024

Thanks @ElectricalBoy that checks out.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you

@SoftFever SoftFever merged commit fa7a11f into SoftFever:main Aug 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants