Remove "auto" wall direction option #6193
Open
+27
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very clever |
vovodroid
force-pushed
the
wall-dir-refactor-pr
branch
from
966b99e
to
40dd3ac
Compare
|
@vovodroid |
|
No, this PR is only base for other changes addressed in my fork. Probably these changes fix your issue. |
vovodroid
force-pushed
the
wall-dir-refactor-pr
branch
from
0f2636d
to
c2b304b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of Allow specify wall directions #4156.
Simplify wall direction option. It assists with further wall related development. For example I separated between internal and overhang walls reversing, and added option to print overhangs after internal to improve adhesion while keeping external wall first for outer-inner and inner-outer-inner modes.
I hope current direction logic was kept. Let me know if something is missed.