Skip to content

Commit

Permalink
ENH: revert the bridge change
Browse files Browse the repository at this point in the history
Find some problem for the change of bridge, revert.

Signed-off-by: salt.wei <[email protected]>
Change-Id: Ib195a9b4425fa54408bcd3842bbafc41a3c79409
  • Loading branch information
SaltWei authored and lanewei120 committed Sep 30, 2022
1 parent 05bee8d commit 63a33c8
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/libslic3r/BridgeDetector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,27 +119,25 @@ bool BridgeDetector::detect_angle(double bridge_direction_override)
}

double total_length = 0;
double arachored_length = 0;
double max_length = 0;
{
Lines clipped_lines = intersection_ln(lines, clip_area);
for (size_t i = 0; i < clipped_lines.size(); ++i) {
const Line &line = clipped_lines[i];
double len = line.length();
total_length += len;
if (expolygons_contain(this->_anchor_regions, line.a) && expolygons_contain(this->_anchor_regions, line.b)) {
// This line could be anchored.
arachored_length += len;
double len = line.length();
total_length += len;
max_length = std::max(max_length, len);
}
}
}
if (arachored_length == 0.)
if (total_length == 0.)
continue;

have_coverage = true;
// Sum length of bridged lines.
candidates[i_angle].coverage = arachored_length / total_length;
candidates[i_angle].coverage = total_length;
/* The following produces more correct results in some cases and more broken in others.
TODO: investigate, as it looks more reliable than line clipping. */
// $directions_coverage{$angle} = sum(map $_->area, @{$self->coverage($angle)}) // 0;
Expand Down

0 comments on commit 63a33c8

Please sign in to comment.