feat: page info validation #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Viczei
changed the base branch from
master
to
1007-admin-liste-des-contenus-modifiés-lors-dune-maj-des-données
Viczei
commented
Sep 28, 2023
| @@ -88,7 +89,7 @@ | |||
| "urql": "^2.0.5", | |||
| "uuid": "^8.3.2", | |||
| "wonka": "^4.0.15", | |||
| "zod": "^3.22.2" | |||
| "zod": "3.21.4" | |||
There was a problem hiding this comment.
j'ai baissé la version car la 3.22 n'est pas compatible avec react-hook-form
Viczei
commented
Sep 28, 2023
Comment on lines
-20
to
-22
| if (value === undefined) { | ||
| return <></>; | ||
| } |
There was a problem hiding this comment.
Bug d'affichage de la checkbox
Viczei
had a problem deploying
to
review-auto
GitHub Actions
Failure
Viczei
merged commit 8d89913
into
1007-admin-liste-des-contenus-modifiés-lors-dune-maj-des-données
4 of 6 checks passed
|
Kudos, SonarCloud Quality Gate passed!
|
added 2 commits
September 28, 2023 12:45
Viczei
added a commit
that referenced
this pull request
Oct 6, 2023
… - page info (#1013) * feat: implementation du schéma de donnée page info * feat: implementation des pages info * fix: review * refactor: implement page info refactor * feat: implementation page creation * feat: add upsert + publish * feat: publish * feat: publish + refactor to module * chore: remove npmrc * fix: publish dep * feat: page info validation (#1040) * feat: zod validation page info * feat: implementation page info validation avec zod * feat: clean deepPartial * chore: clean --------- Co-authored-by: Victor Zeinstra <[email protected]> * chore: clean * chore: clean * chore: use helper text for error * feat: change url to regex check for files * chore: add test * chore: review * chore: yarn * refactor: use confirm modal * chore: downgrade next * fix: breadcrumb display * chore: clean --------- Co-authored-by: Victor Zeinstra <[email protected]>
m-maillot
added a commit
that referenced
this pull request
Oct 9, 2023
* feat: implementation du schéma de donnée page info * feat: implementation des pages info * fix: review * refactor: implement page info refactor * feat: implementation page creation * feat: add upsert + publish * feat: publish * feat: publish + refactor to module * chore: remove npmrc * fix: publish dep * feat: page info validation (#1040) * feat: zod validation page info * feat: implementation page info validation avec zod * feat: clean deepPartial * chore: clean --------- Co-authored-by: Victor Zeinstra <[email protected]> * chore: clean * chore: clean * chore: use helper text for error * feat: change url to regex check for files * chore: add test * chore: review * chore: yarn * refactor: use confirm modal * chore: downgrade next * feat: ajout des validations au formulaire contribution * feat: gérer le cas des fiches SP * chore: clean * feat: contrib answer CC hover + CC search + delete question * Revert "feat: contrib answer CC hover + CC search + delete question" This reverts commit 01e1ded. * chore: add TU * chore: add TU * chore: review * chore: review * chore: review * chore: review * feat: contribution cc hover cc search delete question (#1057) * feat: contrib answer CC hover + CC search + delete question * fix: permettre accordéon dans accordéon * chore: review * chore: fix test --------- Co-authored-by: Victor Zeinstra <[email protected]> * fix: url can be empty --------- Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: Martial Maillot <[email protected]>
m-maillot
added a commit
that referenced
this pull request
Oct 24, 2023
… prod et pre-prod (#1064) * feat: implementation du schéma de donnée page info * feat: implementation des pages info * fix: review * refactor: implement page info refactor * feat: implementation page creation * feat: add upsert + publish * feat: publish * feat: publish + refactor to module * chore: remove npmrc * fix: publish dep * feat: page info validation (#1040) * feat: zod validation page info * feat: implementation page info validation avec zod * feat: clean deepPartial * chore: clean --------- Co-authored-by: Victor Zeinstra <[email protected]> * chore: clean * chore: clean * chore: use helper text for error * feat: change url to regex check for files * chore: add test * chore: review * chore: yarn * refactor: use confirm modal * chore: downgrade next * feat(MAJ prod): lister les documents déployés lors des mises à jours de prod et pre-prod * clean-up * feat(admin) ajout de la page info * show list docs in table * fix: doublons sur publier + lien contenus * chore: fix ts * fix: remove column cdtnId from queries * fix: block type not displaying * fix: graphic validation + order duplicate key * chore: fix types * fix: use mapping to create graphql request * revert * fix types * fix: issues with mapping and requests * fix: issues with publish * fix: migration order * chore: clean * use query instead of API to load docs * remove unused * markup * fix layout --------- Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: Victor Zeinstra <[email protected]> Co-authored-by: Martial Maillot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.