Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manhuagui): incorrect chapter order #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dyphire
Copy link

@dyphire dyphire commented Oct 21, 2024

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really change the chapter ordering? you're reversing the way you parse all the elements, but then you reverse the whole chapter list again, so doesn't it end up being the same? do you have an example manga that has incorrect ordering with the old version but is fixed with this version?

@@ -36,8 +36,7 @@ impl Decoder {
String::new()
};

let suffix_vec = vec![
self.tr(c % self.a, 36),
let suffix_vec = [self.tr(c % self.a, 36),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the formatting here changed? it was better before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy would complain about it when testing in my repository, so fix that.

src/rust/zh.manhuagui/res/source.json Outdated Show resolved Hide resolved
@dyphire
Copy link
Author

dyphire commented Oct 21, 2024

does this really change the chapter ordering? you're reversing the way you parse all the elements, but then you reverse the whole chapter list again, so doesn't it end up being the same? do you have an example manga that has incorrect ordering with the old version but is fixed with this version?

This is not true, it is done because of the special structure of the chapter list in this web page, which was overlooked by the previous people who implemented this source.
It can be confirmed by checking the web page on PC: https://www.manhuagui.com/comic/28004/

image

image

manhuagui v2:
IMG_4931
This PR:
IMG_4933
IMG_4932

@dyphire
Copy link
Author

dyphire commented Oct 22, 2024

Any more problems here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants