-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manhuagui): incorrect chapter order #785
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this really change the chapter ordering? you're reversing the way you parse all the elements, but then you reverse the whole chapter list again, so doesn't it end up being the same? do you have an example manga that has incorrect ordering with the old version but is fixed with this version?
@@ -36,8 +36,7 @@ impl Decoder { | |||
String::new() | |||
}; | |||
|
|||
let suffix_vec = vec![ | |||
self.tr(c % self.a, 36), | |||
let suffix_vec = [self.tr(c % self.a, 36), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was the formatting here changed? it was better before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy would complain about it when testing in my repository, so fix that.
This is not true, it is done because of the special structure of the chapter list in this web page, which was overlooked by the previous people who implemented this source. |
2aa56f4
to
7e07c35
Compare
7e07c35
to
b6b2928
Compare
Any more problems here? |
Checklist:
nsfw
valueid
even if a source's name or language were changed