Refactor Python examples with a new "util.py" file #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
fabinsch
reviewed
Aug 13, 2024
There was a problem hiding this comment.
good idea @ManifoldFR , thanks for the PR. I think we should address the reg and its good to merge.
fabinsch
previously approved these changes
Aug 13, 2024
ManifoldFR
force-pushed
the
topic/refactor-py-examples
branch
from
488b874
to
91d3dc9
Compare
… to it give reg a meaning
ManifoldFR
force-pushed
the
topic/refactor-py-examples
branch
from
91d3dc9
to
cf43941
Compare
fabinsch
previously approved these changes
Aug 13, 2024
jcarpent
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a bunch of Python examples to use a function from the same
util.pyfileThis helps with my draft PR #345 but should have value in itself