Make it possible to use optional parameters (i.e. support of folders) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using optional parameters it is possible to i.e. save uploaded files to a specific folder.
Closed
FlavioIshii
reviewed
Aug 30, 2020
| @@ -20,14 +23,27 @@ public function __construct($name, $attribute = null, $disk = 'cloudinary', $sto | |||
| { | |||
| parent::__construct($name, $attribute, $disk, $storageCallback); | |||
|
|
|||
| $this->storeAs(function (Request $request) { | |||
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |||
There was a problem hiding this comment.
Suggested change
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |
| $this->store(function(Request $request, $requestAttribute) { |
| @@ -21,14 +21,27 @@ public function __construct($name, $attribute = null, $disk = 'cloudinary', $sto | |||
| { | |||
| parent::__construct($name, $attribute, $disk, $storageCallback); | |||
|
|
|||
| $this->storeAs(function (Request $request) { | |||
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |||
There was a problem hiding this comment.
Suggested change
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |
| $this->store(function(Request $request, $requestAttribute) { |
| @@ -21,7 +23,20 @@ public function __construct($name, $attribute = null, $disk = 'cloudinary', $sto | |||
| { | |||
| parent::__construct($name, $attribute, $disk, $storageCallback); | |||
|
|
|||
| $this->thumbnail(function () { | |||
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |||
There was a problem hiding this comment.
Suggested change
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |
| $this->store(function(Request $request, $requestAttribute) { |
| @@ -20,14 +20,27 @@ public function __construct($name, $attribute = null, $disk = 'cloudinary', $sto | |||
| { | |||
| parent::__construct($name, $attribute, $disk, $storageCallback); | |||
|
|
|||
| $this->storeAs(function (Request $request) { | |||
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |||
There was a problem hiding this comment.
Suggested change
| $this->store(function(Request $request, $model, $attribute, $requestAttribute){ | |
| $this->store(function(Request $request, $requestAttribute) { |
Fix download URL of images using folders
Fix missing dirname on delete
|
@carnevalle @FlavioIshii This looks really interesting. I will take a look at this and see if we can get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for using the optional parameters in the Cloudinary Upload API. The parameters are configurable when creating the field using the
cloudinarymethod, like this