-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feature: use vessel name as mdns instanceName #1300
Open
tkurki
wants to merge
2
commits into
master
Choose a base branch
from
mdns-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
changed the title
feature: use vessel name as mdns serviceName
[WIP] feature: use vessel name as mdns serviceName
Apr 6, 2021
tkurki
changed the title
[WIP] feature: use vessel name as mdns serviceName
[WIP] feature: use vessel name as mdns instanceName
Apr 6, 2021
tkurki
force-pushed
the
mdns-improvements
branch
from
April 7, 2021 05:19
287c2e7
to
325fe1c
Compare
https://tools.ietf.org/html/rfc6763#section-4.1.1 For the http service prefix the vessel name with SK. For the SK service types just use the vessel name.
tkurki
force-pushed
the
mdns-improvements
branch
from
April 7, 2021 05:31
325fe1c
to
d21ad32
Compare
added some comment on #1294 |
Added retries, but haven't tested this with Avahi yet. Could you please give it a try @wellenvogel ? |
Add mdns advertisement retry with instance names that have the retry count appended to the name. Retries 9 times and gives up.
tkurki
force-pushed
the
mdns-improvements
branch
from
April 7, 2021 18:51
a7a7212
to
a456cd8
Compare
I have made some tests with avahi daemon.
|
#1477 introduces the ability to store "serverstate" properties and the mdns naming status could go there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.ietf.org/html/rfc6763#section-4.1.1
For the http service prefix the vessel name with SK.
For the SK service types just use the vessel name.