Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(explorer): fix specificity issue with homepage test #789

Merged
merged 1 commit into from
Oct 22, 2024
Merged

test(explorer): fix specificity issue with homepage test #789

merged 1 commit into from
Oct 22, 2024

Conversation

telestrial
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:00pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:00pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 10:00pm
renterd ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 10:00pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 10:00pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5271e73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@telestrial Graphite App
Copy link
Contributor Author

telestrial commented Oct 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @telestrial and the rest of your teammates on Graphite Graphite

@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from 9110474 to 8b2bd71 Compare October 22, 2024 16:00
@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from 8b2bd71 to 00e443a Compare October 22, 2024 16:51
@telestrial telestrial marked this pull request as ready for review October 22, 2024 16:52
@telestrial telestrial mentioned this pull request Oct 22, 2024
Merged
@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from 00e443a to a4def74 Compare October 22, 2024 18:05
alexfreska
alexfreska reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments.

@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from a4def74 to d3b26f4 Compare October 22, 2024 20:19
@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from d3b26f4 to 396f5b2 Compare October 22, 2024 20:37
@alexfreska alexfreska changed the title feat(explorer): add data-testids to the identity part of the header. test(explorer): fix specificity issue with homepage test Oct 22, 2024
@telestrial telestrial force-pushed the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch from 396f5b2 to 5271e73 Compare October 22, 2024 21:55
@telestrial Graphite App
Copy link
Contributor Author

telestrial commented Oct 22, 2024 •
edited
Loading

Merge activity

  • Oct 22, 6:18 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 22, 6:18 PM EDT: A user merged this pull request with Graphite.

@telestrial telestrial merged commit 95dbaae into main Oct 22, 2024
37 checks passed
@telestrial telestrial deleted the 10-22-feat_explorer_add_data-testids_to_the_identity_part_of_the_header branch October 22, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfreska alexfreska alexfreska approved these changes

Assignees

@telestrial telestrial

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@telestrial @alexfreska