Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DatabaseCleaner with Active Record to truncate tables #294

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Nov 1, 2022

Fixes CI as noted in #81 (comment) cc @sambostock

This fixes Rails edge (7.1) tests, due to rails commit 436277da88507f9aae0874e62f3e61a8546b9683 breaking DatabaseCleaner
@bdewater bdewater mentioned this pull request Nov 2, 2022
@bdewater
Copy link
Contributor Author

bdewater commented Nov 2, 2022

@Mangara you'll have to merge this, I can't anymore :)

@Mangara Mangara merged commit a32a143 into Shopify:main Nov 2, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems November 2, 2022 20:05 Inactive
@bdewater bdewater deleted the remove-database-cleaner branch November 3, 2022 03:23
@sambostock
Copy link
Contributor

Thank you @bdewater!

@lavoiesl lavoiesl mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants