Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for line breaks when starting a new version from GitHub Actions #940

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Add support for line breaks when starting a new version from GitHub Actions #940

merged 6 commits into from
Sep 12, 2023

Conversation

nilsreichardt
Copy link
Member

The current problem was that when passing \n for a new line, \n was escaped.

Jonas-Sander
Jonas-Sander reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this logic that should live in the CLI? Since this is a particularity of GitHub Actions I think we should move this to the .yaml files (so all the input into the CLI is "normal")

@nilsreichardt
Copy link
Member Author

Moved to the action files.

Jonas-Sander
Jonas-Sander approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this way better 👍

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 12, 2023
@nilsreichardt nilsreichardt removed this pull request from the merge queue due to a manual request Sep 12, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit fdbc350 Sep 12, 2023
19 of 21 checks passed
@nilsreichardt nilsreichardt deleted the line-breaks branch September 12, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander