Fix race condition when joining a school class with courses #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature: groups
Jonas-Sander
approved these changes
Oct 31, 2024
|
Nice debugging work! :) |
|
Visit the preview URL for this PR (updated for commit 3543b6c): https://sharezone-test--pr1781-fix-joining-group-cl-p1m7gbd4.web.app (expires Sun, 03 Nov 2024 22:55:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1780, there was a bug where nothing happened after selecting a course to join a class. I added some print statements to understand the problem and found out that when pushing the
_GroupJoinPagepage withNavigator.pushmultiple instances of theGroupJoinBlocwere created (~16 instances). This led to the problem that when later accessing theGroupJoinBlocwithBlocProvider.of(context)a different bloc was returned than the one used when entering the code.Fixes #1780