Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prototype of Google AdMob ads #1760

Merged
merged 49 commits into from
Oct 14, 2024
Merged

Add prototype of Google AdMob ads #1760

merged 49 commits into from
Oct 14, 2024

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Oct 10, 2024

Description

This pull request adds Google AdMob for displaying ads in Sharezone. It's an experiment that we will run in the next weeks. Because we set the tagForUnderAgeOfConsent to true, we don't need to show a consent dialog because only "limited ads" will be displayed.

Use the activation code "ads" to enable ads.

Demo

Dashboard Timetable Homework Info Screen
Screenshot_20241012-221743 Screenshot_20241012-222240 Screenshot_20241012-222232 Screenshot_20241013-184158

Additionally, we show after every fifth homework check a full-screen ad:

Screen.Recording.2024-10-14.at.16.46.09.mov

@github-actions github-actions bot added feature: homework platform: android feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). dependencies Changing, updating, adding or removing one or more dependencies. w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Visit the preview URL for this PR (updated for commit 36131ef):

https://sharezone-test--pr1760-ads-6jxj6bxu.web.app

(expires Thu, 17 Oct 2024 23:12:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added user: pupil / student feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Oct 12, 2024
@Jonas-Sander Jonas-Sander added the build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. label Oct 14, 2024
@Sharezone-Admin
Copy link
Member

Sharezone-Admin commented Oct 14, 2024

⬇️ Builds generated by Codemagic for commit 36131ef ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
iOS QR code
Download link
Android QR code
Download link

(expires Wed, 13 Nov 2024 23:24:42 GMT)
Codemagic build: 670da49eda0827f98a72a04c; comment generated with Codemagic App Preview

@Jonas-Sander
Copy link
Collaborator

For me the ads are not activated after using the code "ads" from the apk of the app-preview.

@Jonas-Sander
Copy link
Collaborator

Jonas-Sander commented Oct 14, 2024

Additionally, we show after every fifth editing/adding homework a full-screen ad:

I thought we wanted to show it after completing a homework? I'm not sure I like it after editing/adding a homework.

@nilsreichardt
Copy link
Member Author

I thought we wanted to show it after completing a homework? I'm not sure I like it after editing/adding a homework.

Yes, I just added to editing/adding a homework because I thought adding it to completing a homework would be harder to add. But it wasn't that complicated - so I replaced it as we discussed 👍

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still not shown on my device, but LGTM

@github-actions github-actions bot added the feature: groups:classes Specific to only classes (instead of e.g. courses) label Oct 14, 2024
@nilsreichardt nilsreichardt added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 2a07153 Oct 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. dependencies Changing, updating, adding or removing one or more dependencies. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: homework feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). platform: android platform: ios testing user: pupil / student w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants