-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prototype of Google AdMob ads #1760
Conversation
Visit the preview URL for this PR (updated for commit 36131ef): https://sharezone-test--pr1760-ads-6jxj6bxu.web.app (expires Thu, 17 Oct 2024 23:12:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
⬇️ Builds generated by Codemagic for commit 36131ef ⬇️ Note: Only Sharezone team members are able to install the iOS app.
(expires Wed, 13 Nov 2024 23:24:42 GMT) |
For me the ads are not activated after using the code "ads" from the apk of the app-preview. |
I thought we wanted to show it after completing a homework? I'm not sure I like it after editing/adding a homework. |
Yes, I just added to editing/adding a homework because I thought adding it to completing a homework would be harder to add. But it wasn't that complicated - so I replaced it as we discussed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are still not shown on my device, but LGTM
Description
This pull request adds Google AdMob for displaying ads in Sharezone. It's an experiment that we will run in the next weeks. Because we set the
tagForUnderAgeOfConsent
totrue
, we don't need to show a consent dialog because only "limited ads" will be displayed.Use the activation code "ads" to enable ads.
Demo
Additionally, we show after every fifth homework check a full-screen ad:
Screen.Recording.2024-10-14.at.16.46.09.mov