Fixed double entry bug when clicking safe homework button again after uploading

[HumanBot000]

Fixed bug #1117 and fixed some grammar mistakes in CONTRIBUTING.md

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Visit the preview URL for this PR (updated for commit cc53a53):

https://sharezone-test--pr1699-double-homeworks-saf-cbxxkhdk.web.app

_{(expires Tue, 13 Aug 2024 10:49:56 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}

[Jonas-Sander]

Hey, thanks for your help! 💙

Right now I can't merge the PR since there is a warning from the Dart analyzer.

To fix this you could either change the _SaveButton to a StatefulWidget or use a StatefulBuilder like shown here:

  @override
  Widget build(BuildContext context) {
    bool isSaving = false;
    return StatefulBuilder(builder: (context, setState) {
      return SaveButton(
        key: HwDialogKeys.saveButton,
        tooltip: "Hausaufgabe speichern",
        onPressed: isSaving
            ? null
            : () {
                setState(() => isSaving = true);
                onPressed(context);
              },
      );
    });
  }

I would recommend using the StatefulBuilder in this case. Additionally I disabled the save button in the case above instead of showing a SnackBar. I think its nicer this way.

Lastly I would be grateful if you could extract the changes to the CONTRIBUTING.md into a seperate PR.

Thanks! :)

[Jonas-Sander]

Since it's a stateless class you can't (or you shouldn't) use a mutable variable. This causes a warning to be shown, which is why the analyzer CI step is failing.

[HumanBot000]

Fixed

[HumanBot000]

Hey, thanks for your help! 💙

Right now I can't merge the PR since there is a warning from the Dart analyzer.

To fix this you could either change the _SaveButton to a StatefulWidget or use a StatefulBuilder like shown here:

  @override
  Widget build(BuildContext context) {
    bool isSaving = false;
    return StatefulBuilder(builder: (context, setState) {
      return SaveButton(
        key: HwDialogKeys.saveButton,
        tooltip: "Hausaufgabe speichern",
        onPressed: isSaving
            ? null
            : () {
                setState(() => isSaving = true);
                onPressed(context);
              },
      );
    });
  }

I would recommend using the StatefulBuilder in this case. Additionally I disabled the save button in the case above instead of showing a SnackBar. I think its nicer this way.

Lastly I would be grateful if you could extract the changes to the CONTRIBUTING.md into a seperate PR.

Thanks! :)

Are you sure that showing nothing is the better way?

[Jonas-Sander]

Hey, thanks for your help! 💙
Right now I can't merge the PR since there is a warning from the Dart analyzer.
To fix this you could either change the _SaveButton to a StatefulWidget or use a StatefulBuilder like shown here:

  @override
  Widget build(BuildContext context) {
    bool isSaving = false;
    return StatefulBuilder(builder: (context, setState) {
      return SaveButton(
        key: HwDialogKeys.saveButton,
        tooltip: "Hausaufgabe speichern",
        onPressed: isSaving
            ? null
            : () {
                setState(() => isSaving = true);
                onPressed(context);
              },
      );
    });
  }

I would recommend using the StatefulBuilder in this case. Additionally I disabled the save button in the case above instead of showing a SnackBar. I think its nicer this way.
Lastly I would be grateful if you could extract the changes to the CONTRIBUTING.md into a seperate PR.
Thanks! :)

Are you sure that showing nothing is the better way?

Yes, I tested it locally and I liked it better. Since there is a "sending data..." SnackBar anyways, the user knows that the data is in transit.

[HumanBot000]

Hey, thanks for your help! 💙
Right now I can't merge the PR since there is a warning from the Dart analyzer.
To fix this you could either change the _SaveButton to a StatefulWidget or use a StatefulBuilder like shown here:

  @override
  Widget build(BuildContext context) {
    bool isSaving = false;
    return StatefulBuilder(builder: (context, setState) {
      return SaveButton(
        key: HwDialogKeys.saveButton,
        tooltip: "Hausaufgabe speichern",
        onPressed: isSaving
            ? null
            : () {
                setState(() => isSaving = true);
                onPressed(context);
              },
      );
    });
  }

I would recommend using the StatefulBuilder in this case. Additionally I disabled the save button in the case above instead of showing a SnackBar. I think its nicer this way.
Lastly I would be grateful if you could extract the changes to the CONTRIBUTING.md into a seperate PR.
Thanks! :)

Are you sure that showing nothing is the better way?

Yes, I tested it locally and I liked it better. Since there is a "sending data..." SnackBar anyways, the user knows that the data is in transit.

Okay

[Jonas-Sander]

LGTM! Thank you :)

[nilsreichardt]

I'm pretty sure this causes a bug if an error occurs during the upload (e.g. network issue) because then the save button is still disabled and the user can't retry.

I think the following change could fix it:

setState(() => isSaving = true);
await onPressed(context);
setState(() => isSaving = false);