Make passing ids to GradesService optional, create GradeInput,SubjectInput classes
#1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
feature: grades
Jonas-Sander
changed the title
GradesService optional (they are generated by the service)GradesService optional, use xxxInput classes
Jonas-Sander
changed the title
GradesService optional, use xxxInput classesGradesService optional, create GradeInput,SubjectInput classes
|
Visit the preview URL for this PR (updated for commit 2addfbe): https://sharezone-test--pr1621-no-id-input-joupe4up.web.app (expires Sat, 11 May 2024 10:18:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the users of the
GradesServiceto not need to generate Ids.SubjectInputandGradeInputclass (have no Id field)addCustomGradeTypeno longer takesGradeType, but rather propertiesGradeclass private since its only used for internal usage ofGradesServicenowFixes #1535