Remove "Erledigt-Status bei Hausaufgaben" as Sharezone advantage (#1715)

This feature was listed on https://sharezone.net/plus which can confuse teachers because they can't buy Sharezone Plus.
SharezoneApp · Aug 20, 2024 · b402b65 · b402b65
1 parent 7d38851
commit b402b65
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 29 deletions.
diff --git a/app/lib/sharezone_plus/page/sharezone_plus_page.dart b/app/lib/sharezone_plus/page/sharezone_plus_page.dart
@@ -113,7 +113,6 @@ class _Advantages extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return SharezonePlusAdvantages(
-      isHomeworkDoneListsFeatureVisible: typeOfUser == TypeOfUser.teacher,
       isHomeworkReminderFeatureVisible: typeOfUser == TypeOfUser.student,
       onOpenedAdvantage: (advantage) {
         final analytics = context.read<SharezonePlusPageController>();

diff --git a/app/lib/sharezone_v2/sz_v2_announcement_dialog.dart b/app/lib/sharezone_v2/sz_v2_announcement_dialog.dart
@@ -245,7 +245,6 @@ class _SharezonePlus extends StatelessWidget {
           _JustText(markdownText: _markdownText2),
           SizedBox(height: 30),
           SharezonePlusAdvantages(
-            isHomeworkDoneListsFeatureVisible: false,
             isHomeworkReminderFeatureVisible: true,
           )
         ],

diff --git a/lib/sharezone_plus/sharezone_plus_page_ui/lib/src/sharezone_plus_advantages.dart b/lib/sharezone_plus/sharezone_plus_page_ui/lib/src/sharezone_plus_advantages.dart
@@ -15,13 +15,11 @@ class SharezonePlusAdvantages extends StatelessWidget {
   const SharezonePlusAdvantages({
     super.key,
     required this.isHomeworkReminderFeatureVisible,
-    required this.isHomeworkDoneListsFeatureVisible,
     this.onOpenedAdvantage,
     this.onGitHubOpen,
   });
 
   final bool isHomeworkReminderFeatureVisible;
-  final bool isHomeworkDoneListsFeatureVisible;
   final ValueChanged<String>? onOpenedAdvantage;
   final VoidCallback? onGitHubOpen;
 
@@ -39,8 +37,6 @@ class SharezonePlusAdvantages extends StatelessWidget {
         _PastEvents(onOpen: onOpenedAdvantage),
         _AddEventsToLocalCalendar(onOpen: onOpenedAdvantage),
         _IcalFeature(onOpen: onOpenedAdvantage),
-        if (isHomeworkDoneListsFeatureVisible)
-          _HomeworkDoneLists(onOpen: onOpenedAdvantage),
         _ReadByInformationSheets(onOpen: onOpenedAdvantage),
         _SelectTimetableBySchoolClass(onOpen: onOpenedAdvantage),
         _MoreStorage(onOpen: onOpenedAdvantage),
@@ -298,27 +294,6 @@ class _HomeworkReminder extends StatelessWidget {
   }
 }
 
-class _HomeworkDoneLists extends StatelessWidget {
-  const _HomeworkDoneLists({
-    required this.onOpen,
-  });
-
-  final ValueChanged<String>? onOpen;
-
-  @override
-  Widget build(BuildContext context) {
-    return _AdvantageTile(
-      onOpen: () {
-        if (onOpen != null) onOpen!('homework_done_lists');
-      },
-      icon: const Icon(Icons.checklist),
-      title: const Text('Erledigt-Status bei Hausaufgaben'),
-      description: const Text(
-          'Erhalte eine Liste mit allen Schüler*innen samt Erledigt-Status für jede Hausaufgabe. Dieses Feature ist nur für Lehrkräfte verfügbar.'),
-    );
-  }
-}
-
 class _ReadByInformationSheets extends StatelessWidget {
   const _ReadByInformationSheets({
     required this.onOpen,

diff --git a/...i/test_goldens/goldens/sharezone_plus_advantages_dark_theme.tablet_portrait.png b/...i/test_goldens/goldens/sharezone_plus_advantages_dark_theme.tablet_portrait.png
diff --git a/.../test_goldens/goldens/sharezone_plus_advantages_light_theme.tablet_portrait.png b/.../test_goldens/goldens/sharezone_plus_advantages_light_theme.tablet_portrait.png
diff --git a/.../test_goldens/goldens/sharezone_plus_faq_section_dark_theme.tablet_portrait.png b/.../test_goldens/goldens/sharezone_plus_faq_section_dark_theme.tablet_portrait.png
diff --git a/...test_goldens/goldens/sharezone_plus_faq_section_light_theme.tablet_portrait.png b/...test_goldens/goldens/sharezone_plus_faq_section_light_theme.tablet_portrait.png
diff --git a/lib/sharezone_plus/sharezone_plus_page_ui/test_goldens/sharezone_plus_page_ui_test.dart b/lib/sharezone_plus/sharezone_plus_page_ui/test_goldens/sharezone_plus_page_ui_test.dart
@@ -37,7 +37,6 @@ void main() {
         await tester.pumpWidgetBuilder(
           const SingleChildScrollView(
             child: SharezonePlusAdvantages(
-              isHomeworkDoneListsFeatureVisible: true,
               isHomeworkReminderFeatureVisible: true,
             ),
           ),

diff --git a/website/lib/sharezone_plus/sharezone_plus_page.dart b/website/lib/sharezone_plus/sharezone_plus_page.dart
@@ -169,7 +169,6 @@ class SharezonePlusPage extends StatelessWidget {
                     ),
                     const SizedBox(height: 18),
                     const SharezonePlusAdvantages(
-                      isHomeworkDoneListsFeatureVisible: true,
                       isHomeworkReminderFeatureVisible: true,
                     ),
                     const SizedBox(height: 18),