compataibility for php 8.2 to stop error Deprecated: Creation of dyna… #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic property $contextSwitch = $this->_helper->getHelper('contextSwitch');
$contextSwitch->addActionContext('ajax-attribute-checker', 'json')->initContext('json');
develart-projects
added
bug
|
@develart-projects why not use a typed property like: public array $contexts;? |
holtkamp
reviewed
Nov 7, 2023
| * compataibility for php 8.2 to stop error Deprecated: Creation of dynamic property | ||
| * @var object | ||
| */ | ||
| public $contexts = null; |
There was a problem hiding this comment.
Because it's PHP and we don't really need that.
There was a problem hiding this comment.
The PHPDoc @var object now suggests it is an object, which it is not, it is an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mic property
file change see attached Zend_Controller_Action
example of code below for controller for ajax json output
class TestController extends Zend_Controller_Action
{
public function init ()
{
$contextSwitch = $this->_helper->getHelper('contextSwitch');
}
public function ajaxAttributeCheckerAction ()
{
}