Fix for very slow chunk processing for larger content in the http res… #354
Conversation
|
Additional information:
|
| // If mbstring overloads substr and strlen functions, we have to | ||
| // override it's internal encoding | ||
| if (function_exists('mb_internal_encoding') && | ||
| ((int) ini_get('mbstring.func_overload')) & 2) { |
There was a problem hiding this comment.
mbstring.func_overload was deprecated in PHP 7.2 and removed in PHP 8.0... But this lib aims to be compatible from PHP 7.1 onward, so... IMHO, this logic needs to be put back.
But I see the bigger optimization about using the offset. Very nice.
There was a problem hiding this comment.
IMHO, this logic needs to be put back
So do we have to change here something, or shall it remain as it is?
There was a problem hiding this comment.
IMHO, this logic needs to be put back
So do we have to change here something, or shall it remain as it is?
It's up to @Shardj , @glensc and I don't know whoever else has permissions to merge.
The above is just my opinion as a fellow user of this library. I am not using mb function overloads in my projects, so I'm not personally affected either way. But if I had merge permissions, I would not merge this without also restoring the function overload logic immediately after.
|
@aleksandar-mitrev I agree with @boenrobot - I would like to merge this one into 1.23, but better to keep overload logic restoration to prevent any possible regression on older projects. Are you able to update the PR, please? |
develart-projects
added
the
requested change
|
@develart-projects just have seen that the PR is still open. |
|
@thomaslauria yep, still awaiting PR update to get this into the master. |
|
@develart-projects mbstring stuff restored |
develart-projects
removed
the
requested change
develart-projects
added
the
to be released
This fix is taken from: https://github.com/zendframework/zend-http/blob/master/src/Response.php