Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a link to Glide Element when available #118

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

andrewduckett
Copy link
Contributor

Add a link attribute to Glide Elements that contain one. By default, the API should function as it did before and ignore the link field entirely. This was a little more involved than originally anticipated mostly due to how serialization works.

A new (optional) parameter exclude_reference_link was added to allow links to be excluded (default) or included (new)
(see: https://docs.servicenow.com/bundle/xanadu-api-reference/page/integrate/inbound-rest/concept/c_TableAPI.html#d230634e1380)

NOTE: I did include some additional tests however I do not have a server to test this against so it's minimal at best.

pysnc/record.py Outdated Show resolved Hide resolved
pysnc/record.py Show resolved Hide resolved
@vetsin
Copy link
Collaborator

vetsin commented Oct 7, 2024

I think the tests failed as it doesn't like to inject secrets from forks, and i haven't figured that out

@vetsin vetsin merged commit d6a4f7d into ServiceNow:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants