Cherry-pick "WIP: Add support for cascade layers (CSS @layer rules)" #25107
+1,308
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on usage, `@layer` has two forms, with two different CSSOM types. One simply lists layer names and the other defines a layer with its contained rules. (cherry picked from commit 1c6133aa523fe29c25b11284d8b3353de0a03c0f)
This causes us to pass all of http://wpt.live/css/css-cascade/parsing/layer.html :^) (cherry picked from commit 4c98906e2c00200d7652abf7df5c044fab64dbfc)
I didn't want to add another set of boilerplatey tree-walking methods, so here's a general-purpose one. :^) `for_each_effective_rule()` walks the tree of effective style rules, and runs the callback on each one, in either pre- or postorder. The previous `for_each_effective_style/keyframes_rule()` methods of `CSSStyleSheet` are then reimplemented in terms of `for_each_effective_rule()`, and we can get rid of their equivalents elsewhere. (cherry picked from commit cbb4be3e5e266da09d145435fe8279a83099f363)
This is done quite simply for now, there are certainly optimizations that can and should be made later. With this we now pass: - http://wpt.live/css/css-cascade/layer-basic.html - http://wpt.live/css/css-cascade/layer-important.html - http://wpt.live/css/css-cascade/layer-statement-copy-crash.html - http://wpt.live/css/css-cascade/layer-stylesheet-sharing-important.html - http://wpt.live/css/css-cascade/layer-stylesheet-sharing.html - http://wpt.live/css/css-cascade/layer-vs-inline-style.html (cherry picked from commit a50da405e9c350266edfc89e5d27f7acddbee422)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1291