Everywhere: Reformat using clang-format 19

[DanShaders]

We run CI to test changes, so what's the point of doing that locally?

[timschumi]

I feel like we might want to hold off on this. Apart from the one fix in the last commit, the changes mostly look like changes that we may want to revert again once clang-format gains the respective option.

[DanShaders]

Hmm, @ADKaster and @spholz liked new pointer-to-member formatting and assembly formatting, respectively.
Personally, I don't really care about pointers-to-member or empty blocks (but I like that that strange {}; construct no longer fools clang-format) but inline assembly formatting always looked very weird to me (and I actually glad it changed).

[Hendiadyoin1]

SideNote: still waiting for clang format to allow us to enable "align consecutive assignments" for enums only

[timschumi]

Hmm, @ADKaster and @spholz liked new pointer-to-member formatting and assembly formatting, respectively. Personally, I don't really care about pointers-to-member or empty blocks (but I like that that strange {}; construct no longer fools clang-format) but inline assembly formatting always looked very weird to me (and I actually glad it changed).

pointer-to-member is something I hadn't seen until now, and I generally don't do much with inline assembly, so I don't really have a strong opinion on those two (I just assumed that assembly looked a bit nicer when aligned).

However, for the {} constructs, it seems like we are strongly preferring {} over { } based on pure usage counts:

$ ag 'return {}' | wc -l
6629
$ ag 'return { }' | wc -l
2
$ ag '{};' | wc -l
10607
$ ag '{ };' | wc -l
70

[DanShaders]

The empty block changes are due to a bug fix that made SpaceInEmptyBlock: true from WebKit preset actually work. New rule in clang-format and empty blocks revert incoming.

See discussion on Discord

[nico]

Re {}: In function decls with empty bodies, clang-format currently produces { } with a space – unless there's an incorrect and needless ; after the brace. Then it used to produce {};. Now it knows that the ; is silly and removes it, and the formats as if it wasn't there. That's a (big!) progression.

So I think if we do want to reformat every 6 months, then this looks like a fairly clean reformat as-is.