Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12: Implement try-catch to avoid exception #13

Closed

Conversation

Sebbo94BY
Copy link
Owner

Instead of throwing the exception, this will catch it and handle it respectively. The bot should automatically retry collecting the data, but if this rare exception occurs, it should not cause a downtime of the bot. Instead if should just handle it like no data has been received.

Closes #12

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (8b8afd8) 19.45% compared to head (540b937) 19.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
- Coverage     19.45%   19.37%   -0.08%     
- Complexity      347      349       +2     
============================================
  Files            54       54              
  Lines          1455     1461       +6     
============================================
  Hits            283      283              
- Misses         1172     1178       +6     
Impacted Files Coverage Δ
...p/Controllers/Helpers/BannerVariableController.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sebbo94BY Sebbo94BY marked this pull request as draft April 19, 2023 23:36
@Sebbo94BY Sebbo94BY closed this Aug 7, 2023
@Sebbo94BY Sebbo94BY deleted the Issue-12-Implement-try-catch-for-servergroup-list branch August 7, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant