fix: disallow transfer

ScuffedNewt · Sep 4, 2024 · 7f970cb · 7f970cb
1 parent 68a2fab
commit 7f970cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/Models/User/UserItem.php b/app/Models/User/UserItem.php
@@ -73,7 +73,7 @@ public function getDataAttribute() {
      * @return array
      */
     public function getIsTransferrableAttribute() {
-        if (!isset($this->data['disallow_transfer']) && $this->item->allow_transfer) {
+        if ((!isset($this->data['disallow_transfer']) || !$this->data['disallow_transfer']) && $this->item->allow_transfer) {
             return true;
         }
 

diff --git a/app/Services/ShopManager.php b/app/Services/ShopManager.php
@@ -169,9 +169,8 @@ public function buyStock($data, $user) {
 
             if (!fillUserAssets($assets, null, $user, 'Shop Purchase', [
                 'data'              => $shopLog->itemData,
-                'disallow_transfer' => $shopStock->disallow_transfer,
                 'notes'             => 'Purchased '.format_date($shopLog->created_at),
-            ])) {
+            ] + ($shopStock->disallow_transfer ? ['disallow_transfer' => true] : []))) {
                 throw new \Exception('Failed to purchase item.');
             }