Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify urls to room name, e.g. WEH-4302 #7

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Xavilien
Copy link
Member

@Xavilien Xavilien commented Sep 5, 2024

Description

Now instead of: https://maps.scottylabs.org/WEH-7/1af9af2c-f6a5-4e43-81cd-9b483c52ae39

We get: https://maps.scottylabs.org/WEH-7500

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This is tested by finding the room on the map and seeing that the hyperlink matches the buildingCode-roomName and that when you access localhost:3000/buildingCode-roomName it goes to the correct room. This has been checked on the following rooms and floors:

  • WEH-7500
  • SC-LL001A (on the EV floor)
  • PH-C1
  • SC-LL900 (on LL floor)
  • [] GHC-3
  • [] SC-EV

Check that nonsense codes don't work

  • [] WWW
  • [] WEH-999
  • [] WEH-7500-9
  • [] GHC-
  • [] WEH--

Test Configuration:

  • Node.js version: 18
  • Desktop/Mobile: Macbook Air M2
  • OS: MacOS Sonoma
  • Browser: Safari

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmumaps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 11:06pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants