-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css improvements 2 #363
base: main
Are you sure you want to change the base?
Css improvements 2 #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current feedback: Overall, not a fan of the new list page look. From a UI perspective, I like the original look more, and I'm not sure we should change it. In regards to the search bar, the changes may or may not be good additions. I'm in favor of dynamic wrapping and neutral towards a stickied header, but this decision should be based on user feedback (most UI changes for old features should be on input from design committee or user feedback). We can collect some input at work sessions/meetings early next semester in regards to the search bar changes. Also, nice catch in the manifest file. Lastly, scrolling is a good change, but requires testing across android and iOS (at work sessions/meetings).
I don't remember changing that much - what specifically did you have in mind when writing this? I did revert the grid spacing though - it was a bit too much.
Alright - I guess we'll put a hold on this for now.
Okay - let me know when we can test. |
If there was too long of a text before it would do this
But now the search bar will wrap to the next line
Open for feedback!